Home Original page

zlib: fix inheritance of DeflateRaw without classes by mcollina · Pull Request #13370 · nodejs/node

@mcollina mcollina added the zlib

Issues and PRs related to the zlib subsystem.

label

Jun 1, 2017

addaleax

addaleax

@mcollina 

Fixes internal/util createClassWrapper to support inheritance
without using classes. The constructor now needs to be defined
using a Symbol.

Fixes: nodejs#13358

jasnell added a commit to jasnell/node that referenced this pull request

Jun 1, 2017

@jasnell

jasnell added a commit that referenced this pull request

Jun 5, 2017 
Using ES6 Classes broke userland code. Revert back to functions.

PR-URL: #13374
Fixes: #13358
Ref: #13370
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

jasnell added a commit that referenced this pull request

Jun 5, 2017 
Using ES6 Classes broke userland code. Revert back to functions.

PR-URL: #13374
Fixes: #13358
Ref: #13370
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>