Home Original page

async_hooks: make sure `.{en|dis}able() === this` by addaleax · Pull Request #13418 · nodejs/node

@addaleax 

Make sure that `hook.enable()` and `hook.disable()` return `hook`
consistently, as the documentation indicates.

@nodejs-github-bot added the async_hooks

Issues and PRs related to the async hooks subsystem.

label

Jun 2, 2017

AndreasMadsen

trevnorris

@addaleax addaleax deleted the async-hooks-enable-return-this branch

June 8, 2017 18:21

addaleax added a commit that referenced this pull request

Jun 8, 2017 
Make sure that `hook.enable()` and `hook.disable()` return `hook`
consistently, as the documentation indicates.

PR-URL: #13418
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>

addaleax added a commit that referenced this pull request

Jun 10, 2017 
Make sure that `hook.enable()` and `hook.disable()` return `hook`
consistently, as the documentation indicates.

PR-URL: #13418
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>