Home Original page

async_hooks: minor refactor to callback invocation by addaleax · Pull Request #13419 · nodejs/node

@nodejs-github-bot added async_hooks

Issues and PRs related to the async hooks subsystem.

async_wrap c++

Issues and PRs that require attention from people who are familiar with C++.

labels

Jun 2, 2017

AndreasMadsen

refack

AndreasMadsen

trevnorris

@addaleax 

Re-use the `init` function wherever possible, and move
`try { … } catch` blocks that result in fatal errors to a larger
scope.

Also make the argument order for `init()` consistent in the codebase.

@addaleax addaleax deleted the async-hooks-callback-calling-refactor branch

June 8, 2017 21:59

sam-github pushed a commit to sam-github/node that referenced this pull request

Jun 8, 2017 
Re-use the `init` function wherever possible, and move
`try { … } catch` blocks that result in fatal errors to a larger
scope.

Also make the argument order for `init()` consistent in the codebase.

PR-URL: nodejs#13419
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

addaleax added a commit that referenced this pull request

Jun 10, 2017 
Re-use the `init` function wherever possible, and move
`try { … } catch` blocks that result in fatal errors to a larger
scope.

Also make the argument order for `init()` consistent in the codebase.

PR-URL: #13419
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>