Home Original page

test: add coverage for napi_property_descriptor by mhdawson · Pull Request #13510 · nodejs/node

@mhdawson 

We did not have test coverage for using a napi_value
pointing to a string or symbol for the name when
creating a property.  Add that coverage.

@nodejs-github-bot added node-api

Issues and PRs related to the Node-API.

test

Issues and PRs related to the tests.

labels

Jun 6, 2017

@mhdawson

jasongin

mhdawson added a commit that referenced this pull request

Jun 9, 2017 
We did not have test coverage for using a napi_value
pointing to a string or symbol for the name when
creating a property.  Add that coverage.

PR-URL: #13510
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>

addaleax pushed a commit that referenced this pull request

Jun 10, 2017 
We did not have test coverage for using a napi_value
pointing to a string or symbol for the name when
creating a property.  Add that coverage.

PR-URL: #13510
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>

gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request

Apr 10, 2018 
We did not have test coverage for using a napi_value
pointing to a string or symbol for the name when
creating a property.  Add that coverage.

PR-URL: nodejs#13510
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>

MylesBorins pushed a commit that referenced this pull request

Apr 16, 2018 
We did not have test coverage for using a napi_value
pointing to a string or symbol for the name when
creating a property.  Add that coverage.

Backport-PR-URL: #19447
PR-URL: #13510
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>