Home Original page

assert: make assert.fail doc compliant by BridgeAR · Pull Request #13862 · nodejs/node

@nodejs-github-bot added assert

Issues and PRs related to the assert subsystem.

errors

Issues and PRs related to JavaScript errors originated in Node.js core.

labels

Jun 22, 2017

@BridgeAR BridgeAR changed the title assert: make doc compliant assert: make assert.fail doc compliant

Jun 22, 2017

@jasnell jasnell added the semver-major

PRs that contain breaking changes and should be released in the next major version.

label

Jun 22, 2017

joyeecheung

refack

refack pushed a commit to refack/node that referenced this pull request

Jul 24, 2017 
PR-URL: nodejs#13862
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

refack pushed a commit to refack/node that referenced this pull request

Jul 24, 2017 
1. Rename private functions
2. Use destructuring
3. Remove obsolete comments

PR-URL: nodejs#13862
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

addaleax pushed a commit that referenced this pull request

Jul 24, 2017 
PR-URL: #13862
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Backport-PR-URL: #14428
Backport-Reviewed-By: Anna Henningsen <anna@addaleax.net>

addaleax pushed a commit that referenced this pull request

Jul 24, 2017 
1. Rename private functions
2. Use destructuring
3. Remove obsolete comments

PR-URL: #13862
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Backport-PR-URL: #14428
Backport-Reviewed-By: Anna Henningsen <anna@addaleax.net>

This was referenced

Sep 21, 2017

BridgeAR added a commit to BridgeAR/node that referenced this pull request

Sep 21, 2017 
1. Rename private functions
2. Use destructuring
3. Remove obsolete comments

PR-URL: nodejs#13862
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

BridgeAR added a commit to BridgeAR/node that referenced this pull request

Sep 21, 2017 
PR-URL: nodejs#13862
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Sep 22, 2017 
1. Rename private functions
2. Use destructuring
3. Remove obsolete comments

Backport-PR-URL: #15516
PR-URL: #13862
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Sep 22, 2017 
Backport-PR-URL: #15516
PR-URL: #13862
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Sep 26, 2017 
1. Rename private functions
2. Use destructuring
3. Remove obsolete comments

Backport-PR-URL: #15516
PR-URL: #13862
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Sep 26, 2017 
Backport-PR-URL: #15516
PR-URL: #13862
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

refack pushed a commit to refack/node that referenced this pull request

Oct 10, 2017 
* refactor the code
  1. Rename private functions
  2. Use destructuring
  3. Remove obsolete comments

* remove eslint rule

PR-URL: nodejs#13862
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>