Home Original page

test: refactor test-tls-env-extra-ca by Trott · Pull Request #13886 · nodejs/node

@Trott added test

Issues and PRs related to the tests.

tls

Issues and PRs related to the tls subsystem.

labels

Jun 23, 2017

benjamingr

richardlau

richardlau

@Trott 

* Use `common.mustCall()` to guarantee callback invocations
* Order modules according to test writing guide

richardlau

Trott added a commit to Trott/io.js that referenced this pull request

Jun 26, 2017 
* Use `common.mustCall()` to guarantee callback invocations
* Order modules according to test writing guide

PR-URL: nodejs#13886
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

addaleax pushed a commit that referenced this pull request

Jun 29, 2017 
* Use `common.mustCall()` to guarantee callback invocations
* Order modules according to test writing guide

PR-URL: #13886
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

addaleax pushed a commit that referenced this pull request

Jul 11, 2017 
* Use `common.mustCall()` to guarantee callback invocations
* Order modules according to test writing guide

PR-URL: #13886
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

addaleax pushed a commit that referenced this pull request

Jul 18, 2017 
* Use `common.mustCall()` to guarantee callback invocations
* Order modules according to test writing guide

PR-URL: #13886
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

MylesBorins pushed a commit that referenced this pull request

Aug 14, 2017 
* Use `common.mustCall()` to guarantee callback invocations
* Order modules according to test writing guide

PR-URL: #13886
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

MylesBorins pushed a commit that referenced this pull request

Aug 15, 2017 
* Use `common.mustCall()` to guarantee callback invocations
* Order modules according to test writing guide

PR-URL: #13886
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

MylesBorins pushed a commit that referenced this pull request

Aug 16, 2017 
* Use `common.mustCall()` to guarantee callback invocations
* Order modules according to test writing guide

PR-URL: #13886
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

This was referenced

Sep 5, 2017

@Trott Trott deleted the refactor-test-tls-env-extra-ca branch

January 13, 2022 22:45