Home Original page

test: fix flaky test-force-repl by Trott · Pull Request #14439 · nodejs/node

@Trott added repl

Issues and PRs related to the REPL subsystem.

test

Issues and PRs related to the tests.

labels

Jul 23, 2017

gibfahn

addaleax

@Trott 

test/parallel/test-force-repl.js has an unnecessary timer that makes the
test flaky under load. Remove it.

Trott added a commit to Trott/io.js that referenced this pull request

Jul 26, 2017 
test/parallel/test-force-repl.js has an unnecessary timer that makes the
test flaky under load. Remove it.

PR-URL: nodejs#14439
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

addaleax pushed a commit that referenced this pull request

Jul 27, 2017 
test/parallel/test-force-repl.js has an unnecessary timer that makes the
test flaky under load. Remove it.

PR-URL: #14439
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins pushed a commit that referenced this pull request

Aug 16, 2017 
test/parallel/test-force-repl.js has an unnecessary timer that makes the
test flaky under load. Remove it.

PR-URL: #14439
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins pushed a commit that referenced this pull request

Aug 16, 2017 
test/parallel/test-force-repl.js has an unnecessary timer that makes the
test flaky under load. Remove it.

PR-URL: #14439
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins pushed a commit that referenced this pull request

Sep 3, 2017 
test/parallel/test-force-repl.js has an unnecessary timer that makes the
test flaky under load. Remove it.

PR-URL: #14439
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins pushed a commit that referenced this pull request

Sep 5, 2017 
test/parallel/test-force-repl.js has an unnecessary timer that makes the
test flaky under load. Remove it.

PR-URL: #14439
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

This was referenced

Sep 5, 2017

@Trott Trott deleted the fix-flaky-test-force-repl branch

January 13, 2022 22:46