Home Original page

test: add block scoping to test-readline-interface by Trott · Pull Request #14615 · nodejs/node

@Trott added readline

Issues and PRs related to the built-in readline module.

test

Issues and PRs related to the tests.

labels

Aug 3, 2017

@Trott 

Use block-scoping in test-readline-interface to avoid side effects and
make tests more modular. (Some contain race conditions and will need to
be moved to the sequential directory if they can't be refactored to
avoid the race condition.)

Trott added a commit to Trott/io.js that referenced this pull request

Aug 7, 2017 
Use block-scoping in test-readline-interface to avoid side effects and
make tests more modular. (Some contain race conditions and will need to
be moved to the sequential directory if they can't be refactored to
avoid the race condition.)

PR-URL: nodejs#14615
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Trott added a commit to Trott/io.js that referenced this pull request

Aug 10, 2017 
Use block-scoping in test-readline-interface to avoid side effects and
make tests more modular. (Some contain race conditions and will need to
be moved to the sequential directory if they can't be refactored to
avoid the race condition.)

PR-URL: nodejs#14615
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@Trott Trott mentioned this pull request

Aug 10, 2017

4 tasks

addaleax pushed a commit that referenced this pull request

Aug 10, 2017 
Use block-scoping in test-readline-interface to avoid side effects and
make tests more modular. (Some contain race conditions and will need to
be moved to the sequential directory if they can't be refactored to
avoid the race condition.)

Backport-PR-URL: #14748
Backport-Reviewed-By: Anna Henningsen <anna@addaleax.net>

PR-URL: #14615
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Sep 19, 2017 
Use block-scoping in test-readline-interface to avoid side effects and
make tests more modular. (Some contain race conditions and will need to
be moved to the sequential directory if they can't be refactored to
avoid the race condition.)

Backport-PR-URL: #14748
Backport-Reviewed-By: Anna Henningsen <anna@addaleax.net>

PR-URL: #14615
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@Trott Trott deleted the refactor-test-readline-interface branch

January 13, 2022 22:46