Home Original page

test: fix test-readline-interface short delay by Azard · Pull Request #14677 · nodejs/node

@Azard

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

Aug 7, 2017

@mscdex mscdex added the readline

Issues and PRs related to the built-in readline module.

label

Aug 7, 2017

@Trott Trott mentioned this pull request

Aug 8, 2017

2 tasks

Trott

@Azard

Trott pushed a commit to Trott/io.js that referenced this pull request

Aug 8, 2017 
Previous unit test delay is too short for parallel test on raspberry pi,
it will fail sometimes.  This PR use common.platformTimeout and widen
the time gap.

PR-URL: nodejs#14677
Ref: nodejs#14674
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

addaleax pushed a commit that referenced this pull request

Aug 10, 2017 
Previous unit test delay is too short for parallel test on raspberry pi,
it will fail sometimes.  This PR use common.platformTimeout and widen
the time gap.

PR-URL: #14677
Ref: #14674
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

@Azard Azard mentioned this pull request

Aug 17, 2017

4 tasks

MylesBorins pushed a commit that referenced this pull request

Sep 19, 2017 
Previous unit test delay is too short for parallel test on raspberry pi,
it will fail sometimes.  This PR use common.platformTimeout and widen
the time gap.

PR-URL: #14677
Ref: #14674
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>