async_hooks: skip sanity checks when disabled by AndreasMadsen · Pull Request #15454 · nodejs/node

async_hooks: skip sanity checks when disabled by AndreasMadsen · Pull Request #15454 · nodejs/node

added c++

Issues and PRs that require attention from people who are familiar with C++.

Issues and PRs related to general changes in the lib or src directory.

labels

This was referenced

Sep 18, 2017

MylesBorins pushed a commit that referenced this pull request

PR-URL: #15454
Ref: #14387
Ref: #14722
Ref: #14717
Ref: #15448
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

addaleax pushed a commit to ayojs/ayo that referenced this pull request

jasnell pushed a commit that referenced this pull request

Ref: #15454
PR-URL: #16318
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>

Qard pushed a commit to ayojs/ayo that referenced this pull request

Qard pushed a commit to ayojs/ayo that referenced this pull request

addaleax pushed a commit to ayojs/ayo that referenced this pull request

addaleax pushed a commit to ayojs/ayo that referenced this pull request

daeyeon added a commit to daeyeon/node that referenced this pull request

This removes a comment relevant to runtime checks for `async_hooks`.

Even if `async_hooks` is experimental, the check pointed by the comment
is performed as default unless either `--no-force-async-hooks-checks`
is given from CLI arguments or any async_hook is enabled.

Refs: nodejs#16318
Refs: nodejs#15454 (comment)

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

daeyeon added a commit to daeyeon/node that referenced this pull request

This removes a comment relevant to runtime checks for `async_hooks`.

Even if `async_hooks` is experimental, the check pointed by the comment
is performed as default unless `--no-force-async-hooks-checks` is given
from CLI arguments.

Refs: nodejs#16318
Refs: nodejs#15454 (comment)

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

daeyeon added a commit to daeyeon/node that referenced this pull request

This removes a comment relevant to runtime checks for `async_hooks`.

Even if `async_hooks` is experimental, the check pointed by the comment
is performed as default unless `--no-force-async-hooks-checks` is given
from CLI arguments.

Refs: nodejs#16318
Refs: nodejs#15454 (comment)

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

daeyeon added a commit to daeyeon/node that referenced this pull request

This removes a comment relevant to runtime checks for `async_hooks`.

Even if `async_hooks` is experimental, the check pointed by the comment
is performed as default unless `--no-force-async-hooks-checks` is given
from CLI arguments.

Refs: nodejs#16318
Refs: nodejs#15454 (comment)

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

daeyeon added a commit to daeyeon/node that referenced this pull request

This removes a comment relevant to runtime checks for `async_hooks`.

Even if `async_hooks` is experimental, the check pointed by the comment
is performed as default unless `--no-force-async-hooks-checks` is given
from CLI arguments.

Refs: nodejs#16318
Refs: nodejs#15454 (comment)

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

aduh95 pushed a commit that referenced this pull request

This removes a comment relevant to runtime checks for `async_hooks`.

Even if `async_hooks` is experimental, the check pointed by the comment
is performed as default unless `--no-force-async-hooks-checks` is given
from CLI arguments.

Refs: #16318
Refs: #15454 (comment)

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

PR-URL: #43317
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

targos pushed a commit that referenced this pull request

This removes a comment relevant to runtime checks for `async_hooks`.

Even if `async_hooks` is experimental, the check pointed by the comment
is performed as default unless `--no-force-async-hooks-checks` is given
from CLI arguments.

Refs: #16318
Refs: #15454 (comment)

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

PR-URL: #43317
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

targos pushed a commit that referenced this pull request

This removes a comment relevant to runtime checks for `async_hooks`.

Even if `async_hooks` is experimental, the check pointed by the comment
is performed as default unless `--no-force-async-hooks-checks` is given
from CLI arguments.

Refs: #16318
Refs: #15454 (comment)

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

PR-URL: #43317
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

targos pushed a commit that referenced this pull request

This removes a comment relevant to runtime checks for `async_hooks`.

Even if `async_hooks` is experimental, the check pointed by the comment
is performed as default unless `--no-force-async-hooks-checks` is given
from CLI arguments.

Refs: #16318
Refs: #15454 (comment)

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

PR-URL: #43317
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

guangwong pushed a commit to noslate-project/node that referenced this pull request

This removes a comment relevant to runtime checks for `async_hooks`.

Even if `async_hooks` is experimental, the check pointed by the comment
is performed as default unless `--no-force-async-hooks-checks` is given
from CLI arguments.

Refs: nodejs/node#16318
Refs: nodejs/node#15454 (comment)

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

PR-URL: nodejs/node#43317
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

This was referenced

Dec 10, 2025