Home Original page

build: call setlocal in vcbuild.bat by danbev · Pull Request #15754 · nodejs/node

@danbev 

Currently the variables set in vcbuild.bat are mostly global and
escape/leak out into the calling process. For example, running
vcbuild.bat test and then echoing the config variable gives:

vcbuild.bat test
...
echo %config%
Release

After this change the same command give:
vcbuild.bat test
...
echo %config%
%config%

@nodejs-github-bot added build

Issues and PRs related to build files or the CI.

windows

Issues and PRs related to the Windows platform.

labels

Oct 3, 2017

danbev added a commit to danbev/node that referenced this pull request

Oct 5, 2017 
Currently the variables set in vcbuild.bat are mostly global and
escape/leak out into the calling process. For example, running
vcbuild.bat test and then echoing the config variable gives:

vcbuild.bat test
...
echo %config%
Release

After this change the same command give:
vcbuild.bat test
...
echo %config%
%config%

PR-URL: nodejs#15754
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Oct 7, 2017 
Currently the variables set in vcbuild.bat are mostly global and
escape/leak out into the calling process. For example, running
vcbuild.bat test and then echoing the config variable gives:

vcbuild.bat test
...
echo %config%
Release

After this change the same command give:
vcbuild.bat test
...
echo %config%
%config%

PR-URL: #15754
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Oct 11, 2017 
Currently the variables set in vcbuild.bat are mostly global and
escape/leak out into the calling process. For example, running
vcbuild.bat test and then echoing the config variable gives:

vcbuild.bat test
...
echo %config%
Release

After this change the same command give:
vcbuild.bat test
...
echo %config%
%config%

PR-URL: #15754
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax pushed a commit to addaleax/ayo that referenced this pull request

Oct 12, 2017 
Currently the variables set in vcbuild.bat are mostly global and
escape/leak out into the calling process. For example, running
vcbuild.bat test and then echoing the config variable gives:

vcbuild.bat test
...
echo %config%
Release

After this change the same command give:
vcbuild.bat test
...
echo %config%
%config%

PR-URL: nodejs/node#15754
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Oct 17, 2017 
Currently the variables set in vcbuild.bat are mostly global and
escape/leak out into the calling process. For example, running
vcbuild.bat test and then echoing the config variable gives:

vcbuild.bat test
...
echo %config%
Release

After this change the same command give:
vcbuild.bat test
...
echo %config%
%config%

PR-URL: #15754
Reviewed-By: James M Snell <jasnell@gmail.com>

@refack refack added the semver-major

PRs that contain breaking changes and should be released in the next major version.

label

Oct 17, 2017

@lance lance mentioned this pull request

Oct 18, 2017

2 tasks

jasnell pushed a commit that referenced this pull request

Oct 18, 2017 
Make sure contributors know to cc @nodejs/build when submitting issues
that are build related (in addition to whatever platform are relevant).

PR-URL: #16298
Ref: #15754 (comment)
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Oct 23, 2017 
Make sure contributors know to cc @nodejs/build when submitting issues
that are build related (in addition to whatever platform are relevant).

PR-URL: #16298
Ref: #15754 (comment)
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

addaleax pushed a commit to ayojs/ayo that referenced this pull request

Oct 26, 2017 
Make sure contributors know to cc @nodejs/build when submitting issues
that are build related (in addition to whatever platform are relevant).

PR-URL: nodejs/node#16298
Ref: nodejs/node#15754 (comment)
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

addaleax pushed a commit to ayojs/ayo that referenced this pull request

Dec 7, 2017 
Make sure contributors know to cc @nodejs/build when submitting issues
that are build related (in addition to whatever platform are relevant).

PR-URL: nodejs/node#16298
Ref: nodejs/node#15754 (comment)
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>