Home Original page

🎨 test: include expected result in error messages by keywordnew · Pull Request #16039 · nodejs/node

@keywordnew 

The script being tested for is expected to be present only if the analytics id is provided. To improve user experience, the error message indicates whether the script is expected to be present or not.

@nodejs-github-bot added doc

Issues and PRs related to the documentations.

test

Issues and PRs related to the tests.

tools

Issues and PRs related to the tools directory.

labels

Oct 6, 2017

BridgeAR

@Trott Trott added the code-and-learn

Issues related to the Code-and-Learn events and PRs submitted during the events.

label

Oct 6, 2017

@keywordnew 

Remove expected result from error message and include actual result for clarity and easier debugging.

tniessen

@keywordnew 

Linter errored for missing semi colon and line length.

BridgeAR

BridgeAR pushed a commit that referenced this pull request

Oct 9, 2017 
PR-URL: #16039
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins pushed a commit that referenced this pull request

Oct 11, 2017 
PR-URL: #16039
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

addaleax pushed a commit to addaleax/ayo that referenced this pull request

Oct 12, 2017 
PR-URL: nodejs/node#16039
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins pushed a commit that referenced this pull request

Oct 17, 2017 
PR-URL: #16039
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins pushed a commit that referenced this pull request

Oct 18, 2017 
PR-URL: #16039
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins pushed a commit that referenced this pull request

Oct 25, 2017 
PR-URL: #16039
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>