Home Original page

doc: fix incorrect vm.createContext usage by tshemsedinov · Pull Request #16059 · nodejs/node

@tshemsedinov 

In code example `vm.createContext` called with new operator by mistake.
It is not a constructor.

@nodejs-github-bot added doc

Issues and PRs related to the documentations.

vm

Issues and PRs related to the vm subsystem.

labels

Oct 7, 2017

TimothyGu

benjamingr

JungMinu

addaleax

tniessen

addaleax pushed a commit that referenced this pull request

Oct 7, 2017 
In code example `vm.createContext` called with new operator by mistake.
It is not a constructor.

PR-URL: #16059
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>

MylesBorins pushed a commit that referenced this pull request

Oct 7, 2017 
In code example `vm.createContext` called with new operator by mistake.
It is not a constructor.

PR-URL: #16059
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>

MylesBorins pushed a commit that referenced this pull request

Oct 11, 2017 
In code example `vm.createContext` called with new operator by mistake.
It is not a constructor.

PR-URL: #16059
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>

addaleax pushed a commit to addaleax/ayo that referenced this pull request

Oct 12, 2017 
In code example `vm.createContext` called with new operator by mistake.
It is not a constructor.

PR-URL: nodejs/node#16059
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>

MylesBorins pushed a commit that referenced this pull request

Oct 17, 2017 
In code example `vm.createContext` called with new operator by mistake.
It is not a constructor.

PR-URL: #16059
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>

MylesBorins pushed a commit that referenced this pull request

Oct 18, 2017 
In code example `vm.createContext` called with new operator by mistake.
It is not a constructor.

PR-URL: #16059
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>

MylesBorins pushed a commit that referenced this pull request

Oct 25, 2017 
In code example `vm.createContext` called with new operator by mistake.
It is not a constructor.

PR-URL: #16059
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>