Home Original page

[v6.x] deps: V8: backport e560815 from upstream by ofrobots · Pull Request #16133 · nodejs/node

@ofrobots

@nodejs-github-bot added v6.x v8 engine

Issues and PRs related to the V8 dependency.

labels

Oct 10, 2017

@ofrobots

addaleax

Qard

Qard approved these changes Oct 11, 2017

@jasnell jasnell changed the title deps: V8: backport e560815 from upstream [v6.x] deps: V8: backport e560815 from upstream

Oct 13, 2017

MylesBorins pushed a commit that referenced this pull request

Oct 13, 2017 
Original commit message:
  [runtime] Fix Array.prototype.concat with complex @@species
  Array.prototype.concat does not properly handle JSProxy species that will
  modify the currently visited array.

  BUG=682194

  Review-Url: https://codereview.chromium.org/2655623004
  Cr-Commit-Position: refs/heads/master@{#42640}

Refs: #12779

PR-URL: #16133
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Oct 25, 2017 
Original commit message:
  [runtime] Fix Array.prototype.concat with complex @@species
  Array.prototype.concat does not properly handle JSProxy species that will
  modify the currently visited array.

  BUG=682194

  Review-Url: https://codereview.chromium.org/2655623004
  Cr-Commit-Position: refs/heads/master@{#42640}

Refs: #12779

PR-URL: #16133
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>