src: remove unused includes from node_wrap.h by danbev · Pull Request #16179

src: remove unused includes from node_wrap.h by danbev · Pull Request #16179 · nodejs/node

added the c++

Issues and PRs that require attention from people who are familiar with C++.

label

Oct 13, 2017

I cannot find any usages of these includes and think they can be
removed.

danbev changed the title ~~src: remove unused includeds from node_wrap.h~~ src: remove unused includes from node_wrap.h

Oct 13, 2017

jasnell pushed a commit that referenced this pull request

Oct 15, 2017

I cannot find any usages of these includes and think they can be
removed.

PR-URL: #16179
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos pushed a commit that referenced this pull request

Oct 18, 2017

I cannot find any usages of these includes and think they can be
removed.

PR-URL: #16179
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax pushed a commit to ayojs/ayo that referenced this pull request

Oct 18, 2017

I cannot find any usages of these includes and think they can be
removed.

PR-URL: nodejs/node#16179
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

danbev deleted the unused-includes-node_wrap.h branch

November 16, 2017 08:36

danbev added a commit to danbev/node that referenced this pull request

Nov 17, 2017

I cannot find any usages of these includes and think they can be
removed.

PR-URL: nodejs#16179
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Nov 28, 2017

I cannot find any usages of these includes and think they can be
removed.

Backport-PR-URL: #17092
PR-URL: #16179
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Nov 28, 2017

I cannot find any usages of these includes and think they can be
removed.

Backport-PR-URL: #17092
PR-URL: #16179
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>