Home Original page

timers: cleanup extraneous property on Immediates by targos · Pull Request #16355 · nodejs/node

@Fishrock123 @targos 

This was originally changed in 6f75b66
but it appears unnecessary and benhcmark results show little difference
without the extra property.

Refs: nodejs#6436

@targos added semver-major

PRs that contain breaking changes and should be released in the next major version.

timers

Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.

labels

Oct 21, 2017

@nodejs-github-bot nodejs-github-bot added the timers

Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.

label

Oct 21, 2017

@targos

Fishrock123

addaleax

apapirovski

targos pushed a commit that referenced this pull request

Oct 23, 2017 
This was originally changed in 6f75b66
but it appears unnecessary and benhcmark results show little difference
without the extra property.

Refs: #6436
PR-URL: #16355
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

@targos targos deleted the timers-cleanup-immediate branch

October 23, 2017 12:43

addaleax pushed a commit to ayojs/ayo that referenced this pull request

Oct 26, 2017 
This was originally changed in 6f75b66
but it appears unnecessary and benhcmark results show little difference
without the extra property.

Refs: nodejs/node#6436
PR-URL: nodejs/node#16355
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

addaleax pushed a commit to ayojs/ayo that referenced this pull request

Dec 7, 2017 
This was originally changed in 6f75b66
but it appears unnecessary and benhcmark results show little difference
without the extra property.

Refs: nodejs/node#6436
PR-URL: nodejs/node#16355
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>