Home Original page

fs: fix stat dev unsigned cast overflow by JLHwung · Pull Request #16705 · nodejs/node

@JLHwung 

The `dev_t` is unsigned on Linux, use Integer::NewFromUnsigned to fix cast overflow

Fixes: nodejs#16496

@nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

fs

Issues and PRs related to the fs subsystem / file system.

v6.x labels

Nov 3, 2017

@JLHwung

bnoordhuis

bnoordhuis

XadillaX

benjamingr

MylesBorins pushed a commit that referenced this pull request

Nov 26, 2017 
The `dev_t` is unsigned on Linux, use Integer::NewFromUnsigned to fix cast overflow

PR-URL: #16705
Fixes: #16496
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Nov 26, 2017 
PR-URL: #16705
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Nov 28, 2017 
The `dev_t` is unsigned on Linux, use Integer::NewFromUnsigned to fix cast overflow

PR-URL: #16705
Fixes: #16496
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Nov 28, 2017 
PR-URL: #16705
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

JLHwung added a commit to hexojs/hexo that referenced this pull request

Dec 6, 2017 
This reverts commit a218422.

Since nodejs/node#16705 is merged, the hotfix is unecessary.

# Conflicts:
#	test/scripts/box/file.js

JLHwung added a commit to hexojs/hexo that referenced this pull request

Dec 7, 2017

JLHwung added a commit to hexojs/hexo that referenced this pull request

Dec 8, 2017

JLHwung added a commit to hexojs/hexo that referenced this pull request

Dec 10, 2017

NoahDragon pushed a commit to hexojs/hexo that referenced this pull request

Dec 16, 2017 
* Revert "hotfix(file): cast dev to uint32"

This reverts commit a218422.

Since nodejs/node#16705 is merged, the hotfix is unecessary.

* test(appveyor): update to exact node.js version

thom4parisot pushed a commit to thom4parisot/hexo that referenced this pull request

Jan 17, 2020 
* Revert "hotfix(file): cast dev to uint32"

This reverts commit a218422.

Since nodejs/node#16705 is merged, the hotfix is unecessary.

* test(appveyor): update to exact node.js version