Home Original page

build: include src\tracing when linting on win by danbev · Pull Request #16720 · nodejs/node

@danbev 

This commit excludes src\tracing\trace_event.h and
src\tracing\trace_event_common.h from the linter but allows the
rest of the files in src\tracing to be examined by the linter
which is similar to what the Makefile does.

@nodejs-github-bot added build

Issues and PRs related to build files or the CI.

windows

Issues and PRs related to the Windows platform.

labels

Nov 3, 2017

danbev added a commit that referenced this pull request

Nov 9, 2017 
This commit excludes src\tracing\trace_event.h and
src\tracing\trace_event_common.h from the linter but allows the
rest of the files in src\tracing to be examined by the linter
which is similar to what the Makefile does.

PR-URL: #16720
Reviewed-By: James M Snell <jasnell@gmail.com>

@danbev danbev deleted the windows-lint-include-tracing branch

November 9, 2017 13:45

evanlucas pushed a commit that referenced this pull request

Nov 13, 2017 
This commit excludes src\tracing\trace_event.h and
src\tracing\trace_event_common.h from the linter but allows the
rest of the files in src\tracing to be examined by the linter
which is similar to what the Makefile does.

PR-URL: #16720
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Nov 17, 2017 
This commit excludes src\tracing\trace_event.h and
src\tracing\trace_event_common.h from the linter but allows the
rest of the files in src\tracing to be examined by the linter
which is similar to what the Makefile does.

PR-URL: #16720
Reviewed-By: James M Snell <jasnell@gmail.com>

danbev added a commit to danbev/node that referenced this pull request

Nov 21, 2017 
This commit excludes src\tracing\trace_event.h and
src\tracing\trace_event_common.h from the linter but allows the
rest of the files in src\tracing to be examined by the linter
which is similar to what the Makefile does.

Refs: nodejs#16720
PR-URL: nodejs#16720
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Nov 26, 2017 
This commit excludes src\tracing\trace_event.h and
src\tracing\trace_event_common.h from the linter but allows the
rest of the files in src\tracing to be examined by the linter
which is similar to what the Makefile does.

Refs: #16720
Backport-PR-URL: #17172
PR-URL: #16720
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Nov 28, 2017 
This commit excludes src\tracing\trace_event.h and
src\tracing\trace_event_common.h from the linter but allows the
rest of the files in src\tracing to be examined by the linter
which is similar to what the Makefile does.

Refs: #16720
Backport-PR-URL: #17172
PR-URL: #16720
Reviewed-By: James M Snell <jasnell@gmail.com>