Home Original page

http2: refactor close/destroy for Http2Stream and Http2Session by jasnell · Pull Request #17406 · nodejs/node

@nodejs-github-bot added the lib / src

Issues and PRs related to general changes in the lib or src directory.

label

Nov 30, 2017

@jasnell jasnell added http2

Issues or PRs related to the http2 subsystem.

wip

Issues and PRs that are still a work in progress.

labels

Nov 30, 2017

@jasnell jasnell changed the title [WIP] http2: refactor close/destroy for Http2Stream and Http2Session http2: refactor close/destroy for Http2Stream and Http2Session

Dec 4, 2017

@jasnell jasnell changed the title http2: refactor close/destroy for Http2Stream and Http2Session [WIP] http2: refactor close/destroy for Http2Stream and Http2Session

Dec 6, 2017

mcollina

mcollina

evanlucas pushed a commit that referenced this pull request

Jan 30, 2018 
Improve documentation of callback signature of
http2Stream.pushStream() function to align with
the changes made in #17406.

PR-URL: #18258
Fixes: #18198
Refs: #17406
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit to MylesBorins/node that referenced this pull request

Apr 12, 2018 
PR-URL: nodejs#17406
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

MylesBorins pushed a commit to MylesBorins/node that referenced this pull request

Apr 12, 2018 
PR-URL: nodejs#17406
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

This is a significant cleanup and refactoring of the
cleanup/close/destroy logic for Http2Stream and Http2Session.
There are significant changes here in the timing and ordering
of cleanup logic, JS apis. and various related necessary edits.