Home Original page

test: remove unnecessary use of common.PORT in addons test by Trott · Pull Request #17563 · nodejs/node

@Trott 

Using port 0 to request an open port from the operating system is
sufficient in openssl-client-cert-engine/test.js.

@Trott added the test

Issues and PRs related to the tests.

label

Dec 9, 2017

richardlau

maclover7

@maclover7 maclover7 added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Dec 11, 2017

Trott added a commit to Trott/io.js that referenced this pull request

Dec 12, 2017 
Using port 0 to request an open port from the operating system is
sufficient in openssl-client-cert-engine/test.js.

PR-URL: nodejs#17563
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Dec 12, 2017 
Using port 0 to request an open port from the operating system is
sufficient in openssl-client-cert-engine/test.js.

PR-URL: #17563
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Dec 12, 2017 
Using port 0 to request an open port from the operating system is
sufficient in openssl-client-cert-engine/test.js.

PR-URL: #17563
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@addaleax addaleax removed the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Dec 13, 2017

@Trott Trott deleted the de-common-port branch

January 13, 2022 22:48