Home Original page

tls: make deprecated tls.createSecurePair() use public API by addaleax · Pull Request #17882 · nodejs/node

@addaleax added semver-major

PRs that contain breaking changes and should be released in the next major version.

tls

Issues and PRs related to the tls subsystem.

labels

Dec 27, 2017

bnoordhuis

JungMinu

BridgeAR

@addaleax addaleax added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Jan 2, 2018

@addaleax 

Make the deprecated `tls.createSecurePair()` method use other public
APIs only (`TLSSocket` in particular).

Since `tls.createSecurePair()` has been runtime-deprecated only
since Node 8, it probably isn’t quite time to remove it yet,
but this patch removes almost all of the code complexity that
is retained by it.

The API, as it is documented, is retained. However, it is very likely
that some users have come to rely on parts of undocumented API
of the `SecurePair` class, especially since some of the existing
tests checked for those. Therefore, this should definitely be
considered a breaking change.

TimothyGu

@addaleax addaleax removed lib / src

Issues and PRs related to general changes in the lib or src directory.

author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

labels

Jan 14, 2018

addaleax added a commit that referenced this pull request

Jan 14, 2018 
Make the deprecated `tls.createSecurePair()` method use other public
APIs only (`TLSSocket` in particular).

Since `tls.createSecurePair()` has been runtime-deprecated only
since Node 8, it probably isn’t quite time to remove it yet,
but this patch removes almost all of the code complexity that
is retained by it.

The API, as it is documented, is retained. However, it is very likely
that some users have come to rely on parts of undocumented API
of the `SecurePair` class, especially since some of the existing
tests checked for those. Therefore, this should definitely be
considered a breaking change.

PR-URL: #17882
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>

This was referenced

Apr 20, 2018