stream: remove unreachable code by lpinca · Pull Request #18239 · nodejs/node
added 2 commits
January 18, 2018 18:39To avoid a function call `BufferList.prototype.concat()` is not called when there is only a buffer in the list. That buffer is instead accessed directly.
labels
Jan 18, 2018lpinca added a commit that referenced this pull request
Jan 24, 2018To avoid a function call `BufferList.prototype.concat()` is not called when there is only a buffer in the list. That buffer is instead accessed directly. PR-URL: #18239 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
lpinca added a commit that referenced this pull request
Jan 24, 2018The `n` argument of `BufferList.prototype.concat()` is not the number of `Buffer` instances in the list, but their total length when concatenated. PR-URL: #18239 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
lpinca
deleted the
remove/unreachable-code
branch
evanlucas pushed a commit that referenced this pull request
Jan 30, 2018To avoid a function call `BufferList.prototype.concat()` is not called when there is only a buffer in the list. That buffer is instead accessed directly. PR-URL: #18239 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
evanlucas pushed a commit that referenced this pull request
Jan 30, 2018The `n` argument of `BufferList.prototype.concat()` is not the number of `Buffer` instances in the list, but their total length when concatenated. PR-URL: #18239 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This was referenced
Apr 7, 2024This was referenced
Apr 7, 2024This was referenced
Apr 7, 2024This was referenced
Apr 7, 2024This was referenced
Apr 8, 2024This was referenced
Oct 21, 2024This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters