Home Original page

assert: do not read Node.js modules by BridgeAR · Pull Request #18322 · nodejs/node

@nodejs-github-bot added assert

Issues and PRs related to the assert subsystem.

errors

Issues and PRs related to JavaScript errors originated in Node.js core.

labels

Jan 23, 2018

jasnell

joyeecheung

joyeecheung

Prevent reading a Node.js module. That could theoretically lead to
false errors being thrown otherwise.
The generatedMessage was wrong in case simple assert was used and
a message was auto generated. This fixed the TODO.

mcollina

joyeecheung

@BridgeAR BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Feb 3, 2018

BridgeAR added a commit to BridgeAR/node that referenced this pull request

Feb 6, 2018 
Prevent reading a Node.js module. That could theoretically lead to
false errors being thrown otherwise.

PR-URL: nodejs#18322
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

BridgeAR added a commit to BridgeAR/node that referenced this pull request

Feb 6, 2018 
The generatedMessage was wrong in case simple assert was used and
a message was auto generated. This fixed the TODO.

PR-URL: nodejs#18322
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Trott

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request

May 8, 2018 
Prevent reading a Node.js module. That could theoretically lead to
false errors being thrown otherwise.

PR-URL: nodejs#18322
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request

May 8, 2018 
The generatedMessage was wrong in case simple assert was used and
a message was auto generated. This fixed the TODO.

PR-URL: nodejs#18322
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

@BridgeAR BridgeAR deleted the simple-assert-internal branch

April 1, 2019 23:38