Home Original page

[backport-v8.x] http: add rawPacket in err of `clientError` event by XadillaX · Pull Request #18370 · nodejs/node

@XadillaX 

The `rawPacket` is the current buffer that just parsed. Adding this
buffer to the error object of `clientError` event is to make it possible
that developers can log the broken packet.

PR-URL: nodejs#17672
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

@nodejs-github-bot added http

Issues or PRs related to the http subsystem.

v8.x labels

Jan 25, 2018

BridgeAR

XadillaX added a commit that referenced this pull request

Feb 8, 2018 
The `rawPacket` is the current buffer that just parsed. Adding this
buffer to the error object of `clientError` event is to make it possible
that developers can log the broken packet.

PR-URL: #18370
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

gibfahn pushed a commit that referenced this pull request

Feb 8, 2018 
The `rawPacket` is the current buffer that just parsed. Adding this
buffer to the error object of `clientError` event is to make it possible
that developers can log the broken packet.

PR-URL: #17672
Backport-PR-URL: #18370
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>