Home Original page

test: fix warnings in addon tests by ofrobots · Pull Request #18810 · nodejs/node

@ofrobots 

The legacy MakeCallback deprecation was resulting in compile time
warnings in adddon tests. Fix them.

Ref: nodejs#18632

@nodejs-github-bot added addons

Issues and PRs related to native addons.

test

Issues and PRs related to the tests.

labels

Feb 16, 2018

@BridgeAR BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Feb 16, 2018

mhdawson

jasnell pushed a commit that referenced this pull request

Feb 16, 2018 
The legacy MakeCallback deprecation was resulting in compile time
warnings in adddon tests. Fix them.

Ref: #18632

PR-URL: #18810
Refs: #18632
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

@ofrobots ofrobots deleted the old-make-callback-warnings branch

February 17, 2018 01:22

MylesBorins pushed a commit that referenced this pull request

Feb 21, 2018 
The legacy MakeCallback deprecation was resulting in compile time
warnings in adddon tests. Fix them.

Ref: #18632

PR-URL: #18810
Refs: #18632
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

MylesBorins pushed a commit that referenced this pull request

Feb 21, 2018 
The legacy MakeCallback deprecation was resulting in compile time
warnings in adddon tests. Fix them.

Ref: #18632

PR-URL: #18810
Refs: #18632
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

MylesBorins pushed a commit that referenced this pull request

Feb 21, 2018 
The legacy MakeCallback deprecation was resulting in compile time
warnings in adddon tests. Fix them.

Ref: #18632

PR-URL: #18810
Refs: #18632
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request

May 8, 2018 
The legacy MakeCallback deprecation was resulting in compile time
warnings in adddon tests. Fix them.

Ref: nodejs#18632

PR-URL: nodejs#18810
Refs: nodejs#18632
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>