Home Original page

stream: 'readable' have precedence over flowing by mcollina · Pull Request #18994 · nodejs/node

@nodejs-github-bot added the stream

Issues and PRs related to the stream subsystem.

label

Feb 26, 2018

vsemozhetbyt

mafintosh

lpinca

@Trott Trott removed the tsc-agenda

Issues and PRs to discuss during the meetings of the TSC.

label

Apr 4, 2018

addaleax

@mcollina 

In Streams3 the 'readable' event/.read() method had a lower precedence
than the `'data'` event that made them impossible to use them together.
This make `.resume()` a no-op if there is a listener for the
`'readable'` event, making the stream non-flowing if there is a
`'data'`  listener.

Fixes: nodejs#18058

addaleax

mcollina added a commit that referenced this pull request

Apr 6, 2018 
In Streams3 the 'readable' event/.read() method had a lower precedence
than the `'data'` event that made them impossible to use them together.
This make `.resume()` a no-op if there is a listener for the
`'readable'` event, making the stream non-flowing if there is a
`'data'`  listener.

Fixes: #18058

PR-URL: #18994
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

This was referenced

Apr 11, 2018

schnittstabil added a commit to schnittstabil/cp-file that referenced this pull request

May 11, 2018

sindresorhus pushed a commit to sindresorhus/copy-file that referenced this pull request

May 12, 2018