http: setEncoding error for incoming socket connections by iSkore · Pull Request #19344

http: setEncoding error for incoming socket connections by iSkore · Pull Request #19344 · nodejs/node

added errors

Issues and PRs related to JavaScript errors originated in Node.js core.

http

Issues or PRs related to the http subsystem.

labels

Mar 14, 2018

BridgeAR added the semver-major

PRs that contain breaking changes and should be released in the next major version.

label

Mar 29, 2018

apapirovski removed the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Apr 19, 2018

jasnell removed this from the 11.0.0 milestone

Oct 17, 2018

iSkore added a commit to iSkore/node that referenced this pull request

May 14, 2020

applied updates from previous pull-requests to disallow
socket.setEncoding before a http connection is parsed.
wrapped socket.setEncoding to throw an error.
previously resulted in a fatal error

Fixes: nodejs#18118
Ref: nodejs#18178
Ref: nodejs#19344

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request

May 23, 2020

Applied updates from previous pull-requests to disallow
socket.setEncoding before a http connection is parsed.
Wrapped `socket.setEncoding` to throw an error.
This previously resulted in a fatal error.

PR-URL: nodejs#33405
Fixes: nodejs#18118
Refs: nodejs#18178
Refs: nodejs#19344
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>