errors: alter and test ERR_TLS_REQUIRED_SERVER_NAME by davidmarkclements · Pull Request #19988 · nodejs/node

@nodejs-github-bot added the errors

Issues and PRs related to JavaScript errors originated in Node.js core.

label

Apr 12, 2018

BridgeAR

@BridgeAR BridgeAR added the semver-major

PRs that contain breaking changes and should be released in the next major version.

label

Apr 13, 2018

@BridgeAR BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Apr 13, 2018

addaleax

lpinca

BridgeAR

@BridgeAR BridgeAR removed the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Apr 15, 2018

davidmarkclements and others added 2 commits

November 13, 2018 21:42
changes the base instance for ERR_TLS_REQUIRED_SERVER_NAME
from Error to TypeError as a more accurate representation
of the error and adds a unit test for missing servername
input that triggers this error in Server.prototype.addContext
Replace ERR_TLS_REQUIRED_SERVER_NAME with ERR_MISSING_ARGS. Update
tls.md documentation so that argument name in documentation reflects the
argument name in code.

BridgeAR

sam-github