test: don't remove empty.txt on win32 by rvagg · Pull Request #2 · nodejs/node
on win32 we use empty.txt in the fixtures directory, otherwise we use a file constructed specifically for this test due to POSIX socket path length limitations, in which case we need to do appropriate cleanup
rvagg
deleted the
test-net-pipe-connect-errors-socket-path-win-fix-2
branch
rvagg added a commit that referenced this pull request
Nov 29, 2014on win32 we use empty.txt in the fixtures directory, otherwise we use a file constructed specifically for this test due to POSIX socket path length limitations, in which case we need to do appropriate cleanup Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> PR-URL: #2
snorp
mentioned this pull request
wbt
mentioned this pull request
ghost
mentioned this pull request
1 task
juanarbol pushed a commit to juanarbol/node that referenced this pull request
Mar 1, 2023Original commit message:
[bigint] Convert BigInt property names to decimal
Hexadecimal/octal/binary BigInt property names should be converted
to decimal, i.e. the following object literals should all be equivalent:
var o = {0xF: 1}, p = {0xFn: 1}, q = {15: 1}, r = {15n: 1}.
Test case by yangwenming@bytedance.com, uploaded at
https://chromium-review.googlesource.com/c/v8/v8/+/3634937
Fixed: v8:10600
Change-Id: Ie1d8a16e95697cd31cbc0784843779c921ce91fa
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3642302
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80490}
Refs: v8/v8@c875e86
PR-URL: nodejs#46501
Refs: v8/v8@c875e86
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
kshaa
mentioned this pull request
sungpaks added a commit to sungpaks/node that referenced this pull request
Jul 29, 2024Subtest nodejs#1, nodejs#2 of test-node-run.js originally matched the error message "Can't read package.json" on non-existent file. However, the subtests failed on Ubuntu20.04. we found that attempting to run a non-existent script like `node --run foo` using the latest version of node results in an error message like `Can't find “scripts” field in package.json` (on Ubuntu20.04, regardless of whether package.json is present in the subpath or not). So we modified the subtest so that if we match either of the two messages, the test passes.
sungpaks added a commit to sungpaks/node that referenced this pull request
Jul 29, 2024Subtest nodejs#1, nodejs#2 of test-node-run.js originally matched the error message "Can't read package.json" on non-existent file. However, the subtests failed on Ubuntu20.04. we found that attempting to run a non-existent script like `node --run foo` using the latest version of node results in an error message like `Can't find “scripts” field in package.json` (on Ubuntu20.04, regardless of whether package.json is present in the subpath or not). So we modified the subtest so that if we match either of the two messages, the test passes.
Qard
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters