Home Original page

benchmark: fix next-tick-depth by apapirovski · Pull Request #20461 · nodejs/node

@apapirovski 

A recent change made this benchmark fail by always finishing
with 0 iterations. Restore a counter variable.

@apapirovski added the benchmark

Issues and PRs related to the benchmark subsystem.

label

May 2, 2018

BridgeAR

@BridgeAR BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

May 2, 2018

@apapirovski

apapirovski added a commit that referenced this pull request

May 3, 2018 
A recent change made these benchmarks fail by always finishing
with 0 iterations. Restore a counter variable.

PR-URL: #20461
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>

MylesBorins pushed a commit that referenced this pull request

May 4, 2018 
A recent change made these benchmarks fail by always finishing
with 0 iterations. Restore a counter variable.

PR-URL: #20461
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>

MylesBorins pushed a commit that referenced this pull request

May 8, 2018 
A recent change made these benchmarks fail by always finishing
with 0 iterations. Restore a counter variable.

PR-URL: #20461
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>