Home Original page

clarification: not EventEmitter but its instance by dagolinuxoid · Pull Request #20537 · nodejs/node

@dagolinuxoid 

this === eventEmitter or this === instance of EventEmitter, but it's this is not EventEmitter.
Maybe adding this=== myEmitter to an example down below is redundant so feel free to modify it as well or rather keep it unchanged.

@nodejs-github-bot added doc

Issues and PRs related to the documentations.

events

Issues and PRs related to the events subsystem / EventEmitter.

labels

May 5, 2018

vsemozhetbyt

addaleax

TimothyGu

@dagolinuxoid 

Looking good? I bound it to 80 chars.

vsemozhetbyt

@vsemozhetbyt vsemozhetbyt added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

May 8, 2018

vsemozhetbyt pushed a commit that referenced this pull request

May 8, 2018 
this === eventEmitter or this === instance of EventEmitter,
but it's this is not EventEmitter.

PR-URL: #20537
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>

MylesBorins pushed a commit that referenced this pull request

May 8, 2018 
this === eventEmitter or this === instance of EventEmitter,
but it's this is not EventEmitter.

PR-URL: #20537
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>

MylesBorins pushed a commit that referenced this pull request

May 8, 2018 
this === eventEmitter or this === instance of EventEmitter,
but it's this is not EventEmitter.

PR-URL: #20537
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>

MylesBorins pushed a commit that referenced this pull request

May 9, 2018 
this === eventEmitter or this === instance of EventEmitter,
but it's this is not EventEmitter.

PR-URL: #20537
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>

Open

Open