Home Original page

crypto: add test case for AES key wrapping by yhwang · Pull Request #20587 · nodejs/node

@yhwang 

Add test cases for AES key wrapping and only detect output length in
cipher case. The reason being is the returned output length is
insufficient in AES key unwrapping case.

Signed-off-by: Yihong Wang <yh.wang@ibm.com>

@nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

crypto

Issues and PRs related to the crypto subsystem.

labels

May 8, 2018

bnoordhuis

tniessen

jasnell

@yhwang yhwang added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

May 9, 2018

targos pushed a commit that referenced this pull request

May 12, 2018 
Add test cases for AES key wrapping and only detect output length in
cipher case. The reason being is the returned output length is
insufficient in AES key unwrapping case.

PR-URL: #20587
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

tniessen pushed a commit to tniessen/node that referenced this pull request

May 13, 2018 
Add test cases for AES key wrapping and only detect output length in
cipher case. The reason being is the returned output length is
insufficient in AES key unwrapping case.

PR-URL: nodejs#20587
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

addaleax pushed a commit that referenced this pull request

May 14, 2018 
Add test cases for AES key wrapping and only detect output length in
cipher case. The reason being is the returned output length is
insufficient in AES key unwrapping case.

Backport-PR-URL: #20706
PR-URL: #20587
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

@yhwang yhwang deleted the add-aes-keywrap-test branch

May 16, 2018 05:35