Home Original page

lib: return directly from packageMainCache by danbev · Pull Request #20591 · nodejs/node

@danbev 

This commit updates readPackage to return directly when calling
packageMainCache instead of storing the result in a local var
and returning later.

targos

approved these changes May 8, 2018

@trivikr trivikr added the lib / src

Issues and PRs related to general changes in the lib or src directory.

label

May 8, 2018

BridgeAR

tniessen

@danbev danbev deleted the loaders_readPackage branch

May 10, 2018 03:23

danbev added a commit that referenced this pull request

May 10, 2018 
This commit updates readPackage to return directly when calling
packageMainCache instead of storing the result in a local var
and returning later.

PR-URL: #20591
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

targos pushed a commit that referenced this pull request

May 12, 2018 
This commit updates readPackage to return directly when calling
packageMainCache instead of storing the result in a local var
and returning later.

PR-URL: #20591
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>