src: use unqualified names in module_wrap.cc by danbev · Pull Request #20594

src: use unqualified names in module_wrap.cc by danbev · Pull Request #20594 · nodejs/node

This commit removes the usage of qualified names for consistency.

added the c++

Issues and PRs that require attention from people who are familiar with C++.

label

May 8, 2018

addaleax added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

May 9, 2018

danbev deleted the vm_unqualified_names_module_wrap branch

May 10, 2018 03:40

danbev added a commit to danbev/node that referenced this pull request

May 10, 2018

This commit removes the usage of qualified names for consistency.

PR-URL: nodejs#20594
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

devsnek removed the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

May 10, 2018

targos pushed a commit that referenced this pull request

May 12, 2018

This commit removes the usage of qualified names for consistency.

PR-URL: #20594
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>