Home Original page

doc: add note about autocrlf required for tests by bzoz · Pull Request #20752 · nodejs/node

@bzoz 

Adds a note to test/README.md that setting autocrlf to true when
checking out sources is required for the tests to run successfully.

Ref: nodejs#18967

@vsemozhetbyt vsemozhetbyt added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

May 15, 2018

Trott

@bzoz

joyeecheung

@BridgeAR BridgeAR removed the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

May 18, 2018

@Trott Trott added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

May 21, 2018

apapirovski

apapirovski pushed a commit that referenced this pull request

May 22, 2018 
Adds a note to test/README.md that setting autocrlf to true when
checking out sources is required for the tests to run successfully.

PR-URL: #20752
Ref: #18967
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

MylesBorins pushed a commit that referenced this pull request

May 22, 2018 
Adds a note to test/README.md that setting autocrlf to true when
checking out sources is required for the tests to run successfully.

PR-URL: #20752
Ref: #18967
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

MylesBorins pushed a commit that referenced this pull request

May 23, 2018 
Adds a note to test/README.md that setting autocrlf to true when
checking out sources is required for the tests to run successfully.

PR-URL: #20752
Ref: #18967
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>