Home Original page

assert: fix wrong message indentation by BridgeAR · Pull Request #20791 · nodejs/node

@nodejs-github-bot added the assert

Issues and PRs related to the assert subsystem.

label

May 16, 2018

@BridgeAR BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

May 17, 2018

XadillaX

@BridgeAR BridgeAR added wip

Issues and PRs that are still a work in progress.

and removed author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

labels

May 19, 2018

@BridgeAR BridgeAR removed the wip

Issues and PRs that are still a work in progress.

label

May 21, 2018

@BridgeAR 

If code is read from a file and that code is indented, it would be
misaligned. This makes sure it has a natural indentation that is
relative to the starting point of the assertion.

mcollina

BridgeAR added a commit to BridgeAR/node that referenced this pull request

May 21, 2018 
If code is read from a file and that code is indented, it would be
misaligned. This makes sure it has a natural indentation that is
relative to the starting point of the assertion.

PR-URL: nodejs#20791
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

MylesBorins pushed a commit that referenced this pull request

May 22, 2018 
If code is read from a file and that code is indented, it would be
misaligned. This makes sure it has a natural indentation that is
relative to the starting point of the assertion.

PR-URL: #20791
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

MylesBorins pushed a commit that referenced this pull request

May 23, 2018 
If code is read from a file and that code is indented, it would be
misaligned. This makes sure it has a natural indentation that is
relative to the starting point of the assertion.

PR-URL: #20791
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

@BridgeAR BridgeAR deleted the indent-assertion-error branch

January 20, 2020 11:33