Home Original page

test: rename and document tls test by addaleax · Pull Request #20820 · nodejs/node

@addaleax 

Add a short description and one question to a TLS test.
Also, rename it since the previous name might unintentionally
evoke connotations to an internet meme that would generally
not be considered appropriate in our context.

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

May 18, 2018

addaleax

@addaleax addaleax added the tls

Issues and PRs related to the tls subsystem.

label

May 18, 2018

benjamingr

@addaleax addaleax added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

May 18, 2018

ryzokuken

apapirovski pushed a commit that referenced this pull request

May 22, 2018 
Add a short description and one question to a TLS test.
Also, rename it since the previous name might unintentionally
evoke connotations to an internet meme that would generally
not be considered appropriate in our context.

PR-URL: #20820
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>

MylesBorins pushed a commit that referenced this pull request

May 22, 2018 
Add a short description and one question to a TLS test.
Also, rename it since the previous name might unintentionally
evoke connotations to an internet meme that would generally
not be considered appropriate in our context.

PR-URL: #20820
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>

MylesBorins pushed a commit that referenced this pull request

May 23, 2018 
Add a short description and one question to a TLS test.
Also, rename it since the previous name might unintentionally
evoke connotations to an internet meme that would generally
not be considered appropriate in our context.

PR-URL: #20820
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>