Home Original page

test: add promise API test for appendFile() by Trott · Pull Request #20842 · nodejs/node

@Trott 

Apply the second of five test cases in test-fs-append-fil to the
promise-based API in addition to the callback-based API.

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

May 20, 2018

BridgeAR

@BridgeAR BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

May 20, 2018

benjamingr

apapirovski pushed a commit that referenced this pull request

May 22, 2018 
Apply the second of five test cases in test-fs-append-fil to the
promise-based API in addition to the callback-based API.

PR-URL: #20842
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

MylesBorins pushed a commit that referenced this pull request

May 22, 2018 
Apply the second of five test cases in test-fs-append-fil to the
promise-based API in addition to the callback-based API.

PR-URL: #20842
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

MylesBorins pushed a commit that referenced this pull request

May 23, 2018 
Apply the second of five test cases in test-fs-append-fil to the
promise-based API in addition to the callback-based API.

PR-URL: #20842
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

@Trott Trott deleted the more-promise-tests branch

January 13, 2022 22:49