Home Original page

test: define SharedArrayBuffer as a known global by cjihrig · Pull Request #20849 · nodejs/node

@cjihrig 

This commit defines SharedArrayBuffer as a global for all tests,
rather than adding comments to individual tests.

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

May 20, 2018

TimothyGu

BridgeAR

addaleax

@BridgeAR BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

May 20, 2018

benjamingr

tniessen

addaleax pushed a commit that referenced this pull request

May 21, 2018 
This commit defines SharedArrayBuffer as a global for all tests,
rather than adding comments to individual tests.

PR-URL: #20849
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

MylesBorins pushed a commit that referenced this pull request

May 22, 2018 
This commit defines SharedArrayBuffer as a global for all tests,
rather than adding comments to individual tests.

PR-URL: #20849
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

MylesBorins pushed a commit that referenced this pull request

May 23, 2018 
This commit defines SharedArrayBuffer as a global for all tests,
rather than adding comments to individual tests.

PR-URL: #20849
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>