Home Original page

test: use error code rather than message in test by Trott · Pull Request #20859 · nodejs/node

@Trott 

Use err.code checking instead of err.message checking in
test-child-process-fork-closed-channel-segfault.

@Trott added child_process

Issues and PRs related to the child_process subsystem.

test

Issues and PRs related to the tests.

errors

Issues and PRs related to JavaScript errors originated in Node.js core.

labels

May 21, 2018

BridgeAR

thefourtheye

@BridgeAR BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

May 21, 2018

tniessen

richardlau

@Trott Trott added the fast-track

PRs that do not need to wait for 72 hours to land.

label

May 21, 2018

addaleax

Trott added a commit to Trott/io.js that referenced this pull request

May 22, 2018 
Use err.code checking instead of err.message checking in
test-child-process-fork-closed-channel-segfault.

PR-URL: nodejs#20859
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins pushed a commit that referenced this pull request

May 22, 2018 
Use err.code checking instead of err.message checking in
test-child-process-fork-closed-channel-segfault.

PR-URL: #20859
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins pushed a commit that referenced this pull request

May 23, 2018 
Use err.code checking instead of err.message checking in
test-child-process-fork-closed-channel-segfault.

PR-URL: #20859
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@Trott Trott deleted the message-to-code branch

January 13, 2022 22:49