Home Original page

test: remove third argument(string literal) from strictEqual() by AbhimanyuVashisht · Pull Request #20920 · nodejs/node

@AbhimanyuVashisht 

In test/parallel/test-stream-pip-await-drain-push-while-write.js, There are two
calls in it to assert.strictEqual(). Both calls are provided with three
arguments. The third argument in each case is a string literal. Unfortunately,
that will suppress the presentation of the values of the first two arguments in
the case of an AssertionError

This is fixed by removing the third argument from the call. The third argument
in the call is basically a string literal.

Refs: https://www.nodetodo.org/getting-started

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

May 24, 2018

BridgeAR

@BridgeAR BridgeAR added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

fast-track

PRs that do not need to wait for 72 hours to land.

labels

May 25, 2018

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request

May 25, 2018 
Remove obsolete string literals from `assert.strictEqual()` calls in
test/parallel/test-stream-pip-await-drain-push-while-write.js.

PR-URL: nodejs#20920
Refs: https://www.nodetodo.org/getting-started
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

targos pushed a commit that referenced this pull request

May 25, 2018 
Remove obsolete string literals from `assert.strictEqual()` calls in
test/parallel/test-stream-pip-await-drain-push-while-write.js.

PR-URL: #20920
Refs: https://www.nodetodo.org/getting-started
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>