Home Original page

add issue contributing section by max-mapper · Pull Request #21 · nodejs/node

@max-mapper

indutny pushed a commit that referenced this pull request

Dec 2, 2014 
Reviewed-By: Fedor Indutny <fedor@indutny.com>
PR-URL: #21

boingoing pushed a commit to boingoing/node that referenced this pull request

Apr 6, 2017 
* Update Readme with latest Project details

* Updating with review feedback

* Updated participants list in alphabetic order

* Fixed up some spellings

* Fixed the core addon tests URL

* Update README.md

This was referenced

Mar 18, 2020

This was referenced

Sep 12, 2021

mcollina added a commit to mcollina/node that referenced this pull request

Jan 29, 2026 
- Use undefined instead of null for lazy-loaded SEAProvider
- Add validateBoolean for moduleHooks and virtualCwd options
- Use template literal for path concatenation
- Convert VirtualReadStream to use private class fields
- Cache DateNow() result in MemoryEntry constructor

Addresses review comments nodejs#18, nodejs#19, nodejs#21, nodejs#23, nodejs#24, nodejs#29.

mcollina added a commit to mcollina/node that referenced this pull request

Feb 3, 2026 
- Use undefined instead of null for lazy-loaded SEAProvider
- Add validateBoolean for moduleHooks and virtualCwd options
- Use template literal for path concatenation
- Convert VirtualReadStream to use private class fields
- Cache DateNow() result in MemoryEntry constructor

Addresses review comments nodejs#18, nodejs#19, nodejs#21, nodejs#23, nodejs#24, nodejs#29.

mcollina added a commit to mcollina/node that referenced this pull request

Feb 9, 2026 
- Use undefined instead of null for lazy-loaded SEAProvider
- Add validateBoolean for moduleHooks and virtualCwd options
- Use template literal for path concatenation
- Convert VirtualReadStream to use private class fields
- Cache DateNow() result in MemoryEntry constructor

Addresses review comments nodejs#18, nodejs#19, nodejs#21, nodejs#23, nodejs#24, nodejs#29.

mcollina added a commit to mcollina/node that referenced this pull request

Feb 27, 2026 
- Use undefined instead of null for lazy-loaded SEAProvider
- Add validateBoolean for moduleHooks and virtualCwd options
- Use template literal for path concatenation
- Convert VirtualReadStream to use private class fields
- Cache DateNow() result in MemoryEntry constructor

Addresses review comments nodejs#18, nodejs#19, nodejs#21, nodejs#23, nodejs#24, nodejs#29.

mcollina added a commit to mcollina/node that referenced this pull request

Mar 16, 2026 
- Use undefined instead of null for lazy-loaded SEAProvider
- Add validateBoolean for moduleHooks and virtualCwd options
- Use template literal for path concatenation
- Convert VirtualReadStream to use private class fields
- Cache DateNow() result in MemoryEntry constructor

Addresses review comments nodejs#18, nodejs#19, nodejs#21, nodejs#23, nodejs#24, nodejs#29.

mcollina added a commit to mcollina/node that referenced this pull request

Mar 16, 2026 
- Use undefined instead of null for lazy-loaded SEAProvider
- Add validateBoolean for moduleHooks and virtualCwd options
- Use template literal for path concatenation
- Convert VirtualReadStream to use private class fields
- Cache DateNow() result in MemoryEntry constructor

Addresses review comments nodejs#18, nodejs#19, nodejs#21, nodejs#23, nodejs#24, nodejs#29.