zlib: fix memory leak for unused zlib instances by addaleax · Pull Request #21607 · nodejs/node

@nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

zlib

Issues and PRs related to the zlib subsystem.

labels

Jun 30, 2018

tniessen

@addaleax

An oversight in an earlier commit led to a memory leak
in the untypical situation that zlib instances are created
but never used, because zlib handles no longer started
out their life as weak handles.

The bug was introduced in bd20110.

Refs: nodejs#20455

PR-URL: nodejs#21607
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

@addaleax addaleax deleted the zlib-weak-by-default branch

July 3, 2018 17:23

targos pushed a commit that referenced this pull request

Jul 4, 2018
An oversight in an earlier commit led to a memory leak
in the untypical situation that zlib instances are created
but never used, because zlib handles no longer started
out their life as weak handles.

The bug was introduced in bd20110.

Refs: #20455

PR-URL: #21607
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

This was referenced

Jul 18, 2018