fs: improve fs.watch ENOSPC error message by addaleax · Pull Request #21846

fs: improve fs.watch ENOSPC error message by addaleax · Pull Request #21846 · nodejs/node

added errors

Issues and PRs related to JavaScript errors originated in Node.js core.

Issues and PRs related to the fs subsystem / file system.

labels

Jul 17, 2018

addaleax added the wip

Issues and PRs that are still a work in progress.

label

Jul 17, 2018

addaleax removed the wip

Issues and PRs that are still a work in progress.

label

Aug 1, 2018

addaleax added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Sep 11, 2018

addaleax added a commit that referenced this pull request

Sep 22, 2018

Providing `No space left on device` is misleading in this case.
Replace it with something that describes it more accurately.

Refs: https://stackoverflow.com/questions/22475849/node-js-error-enospc/32600959

PR-URL: #21846
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

targos pushed a commit that referenced this pull request

Sep 23, 2018

Providing `No space left on device` is misleading in this case.
Replace it with something that describes it more accurately.

Refs: https://stackoverflow.com/questions/22475849/node-js-error-enospc/32600959

PR-URL: #21846
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

This was referenced

Oct 10, 2018