util,assert: improve comparison performance by BridgeAR · Pull Request #22197 · nodejs/node

@nodejs-github-bot added the lib / src

Issues and PRs related to general changes in the lib or src directory.

label

Aug 8, 2018

benjamingr

@BridgeAR BridgeAR added assert

Issues and PRs related to the assert subsystem.

util

Issues and PRs related to the built-in util module.

and removed blocked

PRs that are blocked by other issues or PRs.

labels

Aug 15, 2018

ryzokuken

addaleax

This significantly improves regular and typed array performance by
not checking the indices keys anymore. This can be done with a V8
API that allows to only retrieve the non indices property keys.

@BridgeAR

addaleax

BridgeAR added a commit to BridgeAR/node that referenced this pull request

Aug 20, 2018
This significantly improves regular and typed array performance by
not checking the indices keys anymore. This can be done with a V8
API that allows to only retrieve the non indices property keys.

PR-URL: nodejs#22197
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

This was referenced

Aug 20, 2018

bmeurer

targos pushed a commit that referenced this pull request

Aug 21, 2018
This significantly improves regular and typed array performance by
not checking the indices keys anymore. This can be done with a V8
API that allows to only retrieve the non indices property keys.

PR-URL: #22197
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

targos pushed a commit that referenced this pull request

Sep 3, 2018
This significantly improves regular and typed array performance by
not checking the indices keys anymore. This can be done with a V8
API that allows to only retrieve the non indices property keys.

PR-URL: #22197
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

This was referenced

Sep 6, 2018

@BridgeAR BridgeAR deleted the improve-comparison-further branch

January 20, 2020 11:35