Home Original page

test: fix cctest URLTest.ToFilePath on Win32 without Intl by jasnell · Pull Request #22265 · nodejs/node

@jasnell added c++

Issues and PRs that require attention from people who are familiar with C++.

test

Issues and PRs related to the tests.

whatwg-url

Issues and PRs related to the WHATWG URL implementation.

labels

Aug 11, 2018

joyeecheung

@jasnell jasnell added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Aug 12, 2018

richardlau

TimothyGu

TimothyGu

BridgeAR

@jasnell 

Skip one specific test that requires ICU

Fixes: nodejs#19051

jasnell added a commit that referenced this pull request

Aug 16, 2018 
Skip one specific test that requires ICU

Fixes: #19051

PR-URL: #22265
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

targos pushed a commit that referenced this pull request

Aug 19, 2018 
Skip one specific test that requires ICU

Fixes: #19051

PR-URL: #22265
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

targos pushed a commit that referenced this pull request

Sep 3, 2018 
Skip one specific test that requires ICU

Fixes: #19051

PR-URL: #22265
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

This was referenced

Sep 6, 2018

Open

This was referenced

Aug 5, 2021