Home Original page

test: remove harmony flags by BridgeAR · Pull Request #22285 · nodejs/node

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

Aug 12, 2018

devsnek

addaleax

@BridgeAR 

v8 6.8 supports all removed flags. For example for BigInt.

devsnek

@BridgeAR BridgeAR changed the title test: remove bigint harmony flag test: remove harmony flags

Aug 13, 2018

@BridgeAR

@trivikr trivikr added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Aug 13, 2018

BridgeAR added a commit to BridgeAR/node that referenced this pull request

Aug 15, 2018 
v8 6.8 supports all removed flags. For example for BigInt.

PR-URL: nodejs#22285
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

targos pushed a commit that referenced this pull request

Aug 19, 2018 
v8 6.8 supports all removed flags. For example for BigInt.

PR-URL: #22285
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

targos pushed a commit that referenced this pull request

Sep 3, 2018 
v8 6.8 supports all removed flags. For example for BigInt.

PR-URL: #22285
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

This was referenced

Sep 6, 2018