Test fix by abelmark · Pull Request #22487

Test fix by abelmark · Pull Request #22487 · nodejs/node

added the test

Issues and PRs related to the tests.

label

Aug 23, 2018

addaleax added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Aug 27, 2018

lundibundi removed the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Aug 29, 2018

Trott previously requested changes Sep 2, 2018

bb29405 lib,src: fix consistent spacing inside braces
76340e3 test: fix RegExp nits
d00e5f1 test: add hijackStdout and hijackStderr
98e54b0 meta: restore original copyright header
3d2aef3 test: s/assert.equal/assert.strictEqual/
7a0e462 test: use eslint to fix var->const/let
ff1efa6 test: use const for all require() calls
9940766 test: fix tests after V8 upgrade
d1aabd6 test: fix style issues after eslint update
02fe821 test: load common.js to test for global leaks
e3f9335 tools: re-enable comma-spacing linter rule
f29762f test: enable linting for tests
3e1b1dd Remove excessive copyright/license boilerplate
0e19476 test: split test in parallel/sequential
Fixes: #22472

addaleax pushed a commit that referenced this pull request

Sep 19, 2018

Fixes: #22472
Co-authored-by: Denys Otrishko <shishugi@gmail.com>

PR-URL: #22487
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos pushed a commit that referenced this pull request

Sep 20, 2018

Fixes: #22472
Co-authored-by: Denys Otrishko <shishugi@gmail.com>

PR-URL: #22487
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

This was referenced

Oct 10, 2018

This was referenced

Oct 11, 2018