Home Original page

Remove /MP from default additonal options by skelliam · Pull Request #22661 · nodejs/node

@skelliam

@nodejs-github-bot added the build

Issues and PRs related to build files or the CI.

label

Sep 2, 2018

@refack refack added the windows

Issues and PRs related to the Windows platform.

label

Sep 2, 2018

@skelliam

refack

refack previously approved these changes Sep 2, 2018

joaocgreis

@skelliam 

this will replace the hardcoded /MP with an implicit /MP that is easier for users to override.

richardlau

joaocgreis

BridgeAR

@BridgeAR BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Sep 5, 2018

bzoz

bzoz approved these changes Sep 5, 2018

tniessen pushed a commit that referenced this pull request

Sep 9, 2018 
PR-URL: #22661
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>

targos pushed a commit that referenced this pull request

Sep 10, 2018 
PR-URL: #22661
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>