net: port isIPv6() to JS by starkwang · Pull Request #22673

net: port isIPv6() to JS by starkwang · Pull Request #22673 · nodejs/node

Porting isIPv6() to JS makes it 2x-5x faster and reduces some
C++ code.

added c++

Issues and PRs that require attention from people who are familiar with C++.

cares

Issues and PRs related to the c-ares dependency or the cares_wrap binding.

net

Issues and PRs related to the net subsystem.

labels

Sep 3, 2018

mscdex previously requested changes Sep 4, 2018

BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Sep 5, 2018

starkwang added a commit that referenced this pull request

Sep 11, 2018

Porting isIPv6() to JS makes it 10%-250% faster in most cases and
reduces some C++ code. This change also adds tests for some edge
cases.

PR-URL: #22673
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Roman Reiss <me@silverwind.io>

targos pushed a commit that referenced this pull request

Sep 11, 2018

Porting isIPv6() to JS makes it 10%-250% faster in most cases and
reduces some C++ code. This change also adds tests for some edge
cases.

PR-URL: #22673
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Roman Reiss <me@silverwind.io>